Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade stack resolver to latest LTS #7

Closed
wants to merge 2 commits into from

Conversation

OlaoluwaM
Copy link
Contributor

I also added a stack yaml for the old LTS version, just in case, though I'm not sure what use it has. Would appreciate it if you could elaborate on that

@OlaoluwaM OlaoluwaM requested a review from pbrisbin November 22, 2024 16:33
@OlaoluwaM OlaoluwaM self-assigned this Nov 22, 2024
@OlaoluwaM
Copy link
Contributor Author

Does the resolver version in the stack-nightly.yaml file need to change?

pbrisbin
pbrisbin previously approved these changes Nov 22, 2024
Copy link
Member

@pbrisbin pbrisbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what use it has. Would appreciate it if you could elaborate on that

You can find more details here: https://illuminate.atlassian.net/wiki/spaces/EN/pages/17185976662/Preferred+Supported+Compilers+in+Haskell+OSS

Does the resolver version in the stack-nightly.yaml file need to change?

"need"? No, because CI always uses --resolver nightly to ensure it runs the latest.

However, I tend to update to whenever I'm doing this work for two reasons:

  1. It indicates when it was last worked on
  2. It makes it easier to test when working on it (it's easy to forget --resolver nightly)

@pbrisbin
Copy link
Member

pbrisbin commented Dec 3, 2024

@OlaoluwaM this can be closed now?

@OlaoluwaM
Copy link
Contributor Author

Yep

@OlaoluwaM OlaoluwaM closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants