allow setting a different extension than .jpg for router pictures

freifunk-darmstadt · Aug 19, 2023 · 41c489d · 41c489d
1 parent 63814b8
commit 41c489d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/app.js b/app.js
@@ -148,6 +148,11 @@ var firmwarewizard = function() {
     PREVIEW_PICTURES_DIR = config.preview_pictures;
   }
 
+  var PREVIEW_PICTURES_EXT = '.jpg';
+  if(config.preview_pictures_ext !== undefined) {
+    PREVIEW_PICTURES_EXT = config.preview_pictures_ext;
+  }
+
   var enabled_device_categories = ['recommended'];
   if ("enabled_device_categories" in config) {
     enabled_device_categories = config.enabled_device_categories;
@@ -502,7 +507,7 @@ var firmwarewizard = function() {
       'version': version,
       'location': location,
       'size': size,
-      'preview': preview+".jpg",
+      'preview': preview,
       'category': device.category
     });
   }
@@ -670,7 +675,7 @@ var firmwarewizard = function() {
 
     var image = document.createElement('img');
 
-    image.src = PREVIEW_PICTURES_DIR+images[vendor][model][latestRevisionIndex].preview;
+    image.src = PREVIEW_PICTURES_DIR+images[vendor][model][latestRevisionIndex].preview+PREVIEW_PICTURES_EXT;
     image.alt = name;
     image.addEventListener('error', firmwarewizard.setDefaultImg);
 
@@ -698,7 +703,7 @@ var firmwarewizard = function() {
   }
 
   function setDefaultImg(e) {
-    fallbackImg = PREVIEW_PICTURES_DIR+'no_picture_available.jpg';
+    fallbackImg = 'pictures/no_picture_available.jpg';
     if (e.target.src.indexOf(fallbackImg) == -1) {
       e.target.src = fallbackImg;
     }

diff --git a/config_template.js b/config_template.js
@@ -57,6 +57,7 @@ var config = {
   experimental_branches: ['experimental'],
   // path to preview pictures directory
   preview_pictures: 'pictures/',
+  preview_pictures_ext: '.jpg',
   // link to changelog
   changelog: 'CHANGELOG.html',
   // links for instructions like flashing of certain devices (optional)