Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make is_gzip_path pub as it's generally useful #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

make is_gzip_path pub as it's generally useful #11

wants to merge 1 commit into from

Conversation

brentp
Copy link

@brentp brentp commented Oct 24, 2023

No description provided.

@brentp brentp mentioned this pull request Oct 24, 2023
Open
@nh13 nh13 requested a review from tfenne October 24, 2023 16:30
nh13
nh13 approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@nh13 nh13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nh13
Copy link
Member

nh13 commented Oct 24, 2023

Shall we update the csv constraint to 1.2 here: https://github.com/fulcrumgenomics/fgoxide/blob/03c417b0b32901e3c35bd1ef8831422eb9280d6f/Cargo.toml#L24C9-L24C10

@nh13
Copy link
Member

nh13 commented Oct 25, 2023

See #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nh13 nh13 nh13 approved these changes

@tfenne tfenne Awaiting requested review from tfenne tfenne is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brentp @nh13