Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OffTargetDetector should not pass primer pairs when no amplicons are … #6

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

OffTargetDetector should not pass primer pairs when no amplicons are … #6

wants to merge 2 commits into from

Conversation

nh13
Copy link
Member

@nh13 nh13 commented Aug 8, 2024

…generated

@nh13 nh13 requested a review from tfenne August 8, 2024 20:59
tfenne
tfenne requested changes Aug 9, 2024
View reviewed changes
Copy link
Member

@tfenne tfenne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's bizarre to me that we don't just separate the mappings into "on" and "off" target, and retain those separately. If we're going to add a constraint here, I think we should do that rather than rely on there being at least 1 mapping.

@nh13
Copy link
Member Author

nh13 commented Aug 10, 2024

@tfenne I made it so when no "amplifiable" amplicons are returned, we return an empty off-target mapping. I also added an explanation to motivate this change. Can you see if it makes more sense to you now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfenne tfenne tfenne requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nh13 @tfenne