Record the version of gnu-efi we built against

[hughsie]

This allows fwupd to detect a known UEFI update problem caused where the distro has updated to gnu-efi 4.0.x and not updated fwupd-efi to 1.7.

[superm1]

Shouldn't we just block it?

[hughsie]

Shouldn't we just block it?

How? I'm open for better ideas.

[superm1]

We could make it a "dependency" of fwupd solely for the reason to block fwupd compilation with capsule support.

[hughsie]

We could make it a "dependency" of fwupd solely for the reason to block fwupd compilation with capsule support.

That would capture the gnu-efi version as compiled, but it wouldn't capture the runtime version. I'm pondering if putting the gnu-efi version in the fwupd-efi sbom is the right thing to do.

[superm1]

We could make it a "dependency" of fwupd solely for the reason to block fwupd compilation with capsule support.

That would capture the gnu-efi version as compiled, but it wouldn't capture the runtime version. I'm pondering if putting the gnu-efi version in the fwupd-efi sbom is the right thing to do.

But isn't it statically linked anyway? Isn't that what we want?

[hughsie]

But isn't it statically linked anyway

right, but even if gnu-efi is statically linked into fwupd-efi -- we can update fwupd-efi without rebuilding fwupd.

[superm1]

Yeah it's not perfect; but thinking about this from a distro angle if they have an old version at compile time for fwupd they probably have an old one at runtime too.

So this could encourage them to fix it. Especially if we detect the fwupd-efi version at compile time too.

[superm1]

@hughsie can you fix the fedora build failure?

[coderabbitai]

Warning

Review limit reached

@hughsie, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 42 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9916c13e-482b-46fd-ae99-94fde525a237

📥 Commits

Reviewing files that changed from the base of the PR and between f47d6bf and 2cea96e.

📒 Files selected for processing (4)

• efi/meson.build
• efi/sbom.cdx.json
• efi/swid.xml.in
• meson.build

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}