Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add components from wc-ribbon repo #3

Merged
merged 8 commits into from
Dec 19, 2024

Conversation

pkalita-lbl
Copy link
Collaborator

Part of #2

These changes bring the components from the wc-ribbon repo. The structure here is to simply bring all the components into a single project (i.e. there is only one package.json file) and not attempt to do a multi-project monorepo for now.

While copying code from the source repo over the following cleanup was done:

  • Use go-* naming convention for component subdirectories. Note that the names of component classes and their associated tag names have not changed yet.
  • Move utilities that are specific to a single component to a src/components/{component-name}/utils.ts file and put code that is shared among multiple components in src/globals
  • Use TypeScript interfaces instead of actual classes in src/globals/models.js
  • Drop some unused code

@pkalita-lbl pkalita-lbl merged commit 32044ec into main Dec 19, 2024
1 check passed
@pkalita-lbl pkalita-lbl deleted the issue-2-add-ribbon-componenets branch December 19, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant