Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add components from the wc-gocam-viz repo #4

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

pkalita-lbl
Copy link
Collaborator

Part of #2

These changes add the components from the wc-gocam-viz repo. Mostly this is just a matter of copying over the code into this repo. However I'll call out these details:

  • The wc-gocam-viz repo has an unusual practice of copying over code from the noctua-form-base repo periodically. Unfortunately, we're considering that bad practice here, but at some point we should figure out a proper way to share code. In the meantime, I'm excluding the src/globals/@noctua.form/ directory from Prettier and ESLint since it is quasi-third party code.
  • The @stencil/core version is being downgraded slightly because of adding the cytoscape-dagre dependency. See the comment in stencil.config.ts for more details on the compatibility issues.
  • I did not copy over the wc-gocam-selector component since it was not used anywhere
  • This repo already had a go-spinner component. The wc-gocam-viz repo had a loading-spinner component. I consolidated them into one component (mostly based on loading-spinner) and updated existing usages of it in other components.

@pkalita-lbl pkalita-lbl merged commit a4415c4 into main Dec 20, 2024
1 check passed
@pkalita-lbl pkalita-lbl deleted the issue-2-add-gocam-components branch December 20, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant