-
-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Session Replay GA #4662
Feat: Session Replay GA #4662
Conversation
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5e579af | 1239.16 ms | 1248.49 ms | 9.33 ms |
5e66a38 | 1209.10 ms | 1233.90 ms | 24.79 ms |
3277f18 | 1229.29 ms | 1248.92 ms | 19.63 ms |
3cba0e8 | 1250.86 ms | 1258.39 ms | 7.53 ms |
7fe37ab | 1228.92 ms | 1243.86 ms | 14.94 ms |
0ecf042 | 1228.25 ms | 1250.67 ms | 22.42 ms |
0970e44 | 1237.32 ms | 1251.53 ms | 14.21 ms |
e773cad | 1221.82 ms | 1240.55 ms | 18.73 ms |
f4a6925 | 1237.29 ms | 1249.35 ms | 12.07 ms |
216bdf9 | 1193.69 ms | 1217.90 ms | 24.21 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5e579af | 21.58 KiB | 656.60 KiB | 635.01 KiB |
5e66a38 | 22.85 KiB | 408.88 KiB | 386.03 KiB |
3277f18 | 22.84 KiB | 402.88 KiB | 380.03 KiB |
3cba0e8 | 22.84 KiB | 403.19 KiB | 380.34 KiB |
7fe37ab | 21.58 KiB | 542.28 KiB | 520.70 KiB |
0ecf042 | 21.58 KiB | 631.82 KiB | 610.24 KiB |
0970e44 | 22.32 KiB | 761.50 KiB | 739.18 KiB |
e773cad | 21.58 KiB | 681.75 KiB | 660.17 KiB |
f4a6925 | 21.58 KiB | 706.47 KiB | 684.89 KiB |
216bdf9 | 21.58 KiB | 418.13 KiB | 396.54 KiB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4662 +/- ##
=============================================
+ Coverage 90.649% 90.667% +0.017%
=============================================
Files 620 621 +1
Lines 71021 71157 +136
Branches 25819 25932 +113
=============================================
+ Hits 64380 64516 +136
+ Misses 6545 6543 -2
- Partials 96 98 +2
... and 21 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, big step 🥇 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
📜 Description
Removes SR from experimental and make it GA.
This PR is a preparation for GA and should only be merged at session replay GA day.
Consider approving and merging the following PR for GA
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps