Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Session Replay GA #4662

Merged
merged 10 commits into from
Jan 2, 2025
Merged

Feat: Session Replay GA #4662

merged 10 commits into from
Jan 2, 2025

Conversation

brustolin
Copy link
Contributor

@brustolin brustolin commented Dec 23, 2024

📜 Description

Removes SR from experimental and make it GA.

This PR is a preparation for GA and should only be merged at session replay GA day.

Consider approving and merging the following PR for GA

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link

github-actions bot commented Dec 23, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 1befb0b

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Dec 23, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1233.41 ms 1258.63 ms 25.22 ms
Size 22.32 KiB 760.69 KiB 738.37 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5e579af 1239.16 ms 1248.49 ms 9.33 ms
5e66a38 1209.10 ms 1233.90 ms 24.79 ms
3277f18 1229.29 ms 1248.92 ms 19.63 ms
3cba0e8 1250.86 ms 1258.39 ms 7.53 ms
7fe37ab 1228.92 ms 1243.86 ms 14.94 ms
0ecf042 1228.25 ms 1250.67 ms 22.42 ms
0970e44 1237.32 ms 1251.53 ms 14.21 ms
e773cad 1221.82 ms 1240.55 ms 18.73 ms
f4a6925 1237.29 ms 1249.35 ms 12.07 ms
216bdf9 1193.69 ms 1217.90 ms 24.21 ms

App size

Revision Plain With Sentry Diff
5e579af 21.58 KiB 656.60 KiB 635.01 KiB
5e66a38 22.85 KiB 408.88 KiB 386.03 KiB
3277f18 22.84 KiB 402.88 KiB 380.03 KiB
3cba0e8 22.84 KiB 403.19 KiB 380.34 KiB
7fe37ab 21.58 KiB 542.28 KiB 520.70 KiB
0ecf042 21.58 KiB 631.82 KiB 610.24 KiB
0970e44 22.32 KiB 761.50 KiB 739.18 KiB
e773cad 21.58 KiB 681.75 KiB 660.17 KiB
f4a6925 21.58 KiB 706.47 KiB 684.89 KiB
216bdf9 21.58 KiB 418.13 KiB 396.54 KiB

Previous results on branch: feat/GA-SR

Startup times

Revision Plain With Sentry Diff
7e4b776 1228.94 ms 1250.76 ms 21.82 ms

App size

Revision Plain With Sentry Diff
7e4b776 22.32 KiB 760.70 KiB 738.38 KiB

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.667%. Comparing base (52523e7) to head (1befb0b).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4662       +/-   ##
=============================================
+ Coverage   90.649%   90.667%   +0.017%     
=============================================
  Files          620       621        +1     
  Lines        71021     71157      +136     
  Branches     25819     25932      +113     
=============================================
+ Hits         64380     64516      +136     
+ Misses        6545      6543        -2     
- Partials        96        98        +2     
Files with missing lines Coverage Δ
Sources/Sentry/SentryBaseIntegration.m 97.777% <100.000%> (+1.400%) ⬆️
Sources/Sentry/SentryOptions.m 98.558% <100.000%> (-0.160%) ⬇️
Sources/Sentry/SentrySessionReplayIntegration.m 89.500% <100.000%> (-0.027%) ⬇️
Sources/Swift/SentryExperimentalOptions.swift 0.000% <ø> (-100.000%) ⬇️
...onReplay/SentrySessionReplayIntegrationTests.swift 98.825% <100.000%> (ø)
Tests/SentryTests/SentryOptionsTest.m 98.454% <100.000%> (-0.002%) ⬇️

... and 21 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52523e7...1befb0b. Read the comment docs.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, big step 🥇 🚀

Copy link
Contributor

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@philipphofmann philipphofmann merged commit 0aea1a1 into main Jan 2, 2025
73 checks passed
@philipphofmann philipphofmann deleted the feat/GA-SR branch January 2, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants