Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove empty session replay tags #4667

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

philipphofmann
Copy link
Member

📜 Description

Don't add maskedViewClasses and unmaskedViewClasses when being empty.

💡 Motivation and Context

Slightly improves the situation for #4666.

💚 How did you test it?

Unit tests.

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Don't add maskedViewClasses and unmaskedViewClasses when being empty.
Copy link
Contributor

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.661%. Comparing base (0aea1a1) to head (b129072).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4667       +/-   ##
=============================================
- Coverage   90.664%   90.661%   -0.004%     
=============================================
  Files          621       621               
  Lines        71157     71165        +8     
  Branches     25931     25944       +13     
=============================================
+ Hits         64514     64519        +5     
- Misses        6545      6547        +2     
- Partials        98        99        +1     
Files with missing lines Coverage Δ
.../SessionReplay/RRWeb/SentryRRWebOptionsEvent.swift 100.000% <100.000%> (ø)
...tions/SessionReplay/SentrySessionReplayTests.swift 99.069% <100.000%> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0aea1a1...b129072. Read the comment docs.

Copy link

github-actions bot commented Jan 2, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1240.38 ms 1262.10 ms 21.72 ms
Size 22.31 KiB 760.65 KiB 738.33 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
eaf3840 1264.94 ms 1274.04 ms 9.10 ms
794f87f 1225.78 ms 1243.46 ms 17.68 ms
ff09c7e 1244.86 ms 1246.68 ms 1.82 ms
bd2afa6 1241.37 ms 1246.20 ms 4.83 ms
8d16504 1235.50 ms 1258.76 ms 23.26 ms
3723833 1224.71 ms 1247.92 ms 23.21 ms
3cba0e8 1236.29 ms 1271.21 ms 34.92 ms
3277f18 1229.29 ms 1248.92 ms 19.63 ms
ac8fd53 1201.42 ms 1214.55 ms 13.13 ms
e324230 1244.43 ms 1252.98 ms 8.55 ms

App size

Revision Plain With Sentry Diff
eaf3840 22.84 KiB 401.67 KiB 378.83 KiB
794f87f 20.76 KiB 401.37 KiB 380.61 KiB
ff09c7e 20.76 KiB 427.77 KiB 407.00 KiB
bd2afa6 20.76 KiB 420.55 KiB 399.79 KiB
8d16504 20.76 KiB 434.92 KiB 414.16 KiB
3723833 21.58 KiB 424.34 KiB 402.76 KiB
3cba0e8 22.84 KiB 403.19 KiB 380.34 KiB
3277f18 22.84 KiB 402.88 KiB 380.03 KiB
ac8fd53 21.58 KiB 419.81 KiB 398.22 KiB
e324230 22.85 KiB 408.88 KiB 386.03 KiB

@philipphofmann philipphofmann merged commit f278bab into main Jan 2, 2025
70 checks passed
@philipphofmann philipphofmann deleted the fix/remove-empty-replay-tags branch January 2, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants