Conversation
SentrySwiftUI is now built and distributed from the binary repo. Remove the XCFramework build, API extraction, and stability check for SentrySwiftUI from the main repo. - Remove SentrySwiftUI build + extraction from update-api.sh - Remove SentrySwiftUI API stability check from api-stability workflow - Remove sdk_api_sentryswiftui.json from file filters and repo - Update AGENTS.md to stop referencing sdk_api_sentryswiftui.json Part of COCOA-1685
Contributor
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
itaybre
added
v10 Change
run-full-ci
📲 Install BuildsiOS
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c4d02bd | 1219.63 ms | 1248.68 ms | 29.05 ms |
| 7f28cd4 | 1215.77 ms | 1242.98 ms | 27.21 ms |
| e3070ad | 1201.60 ms | 1235.70 ms | 34.10 ms |
| 59213ba | 1223.66 ms | 1258.02 ms | 34.36 ms |
| 23b642a | 1235.62 ms | 1270.53 ms | 34.92 ms |
| 4da7fcb | 1209.38 ms | 1251.78 ms | 42.40 ms |
| 787537a | 1218.35 ms | 1251.72 ms | 33.38 ms |
| 8263068 | 1240.93 ms | 1260.29 ms | 19.36 ms |
| 586d4e0 | 1201.16 ms | 1246.84 ms | 45.67 ms |
| dcb456a | 1220.98 ms | 1246.74 ms | 25.76 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c4d02bd | 24.14 KiB | 1.17 MiB | 1.14 MiB |
| 7f28cd4 | 24.14 KiB | 1.23 MiB | 1.21 MiB |
| e3070ad | 24.14 KiB | 1.16 MiB | 1.14 MiB |
| 59213ba | 24.14 KiB | 1.22 MiB | 1.20 MiB |
| 23b642a | 24.14 KiB | 1.24 MiB | 1.22 MiB |
| 4da7fcb | 24.14 KiB | 1.18 MiB | 1.16 MiB |
| 787537a | 24.14 KiB | 1.15 MiB | 1.12 MiB |
| 8263068 | 24.14 KiB | 1.24 MiB | 1.21 MiB |
| 586d4e0 | 24.14 KiB | 1.26 MiB | 1.23 MiB |
| dcb456a | 24.14 KiB | 1.22 MiB | 1.20 MiB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove SentrySwiftUI XCFramework build, API extraction, and API stability check from the main repo. SentrySwiftUI is no longer needed since it is part of the main Sentry target
Changes:
scripts/update-api.sh— remove SentrySwiftUI XCFramework build and API extraction steps.github/workflows/api-stability.yml— remove SentrySwiftUI API stability check step and base file rename.github/file-filters.yml— removesdk_api_sentryswiftui.jsonfrom API stability trigger filesAGENTS.md— remove reference tosdk_api_sentryswiftui.jsonin public API regeneration instructionssdk_api_sentryswiftui.jsonPart of COCOA-1685
#skip-changelog