Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
sdk-develop-docs
|
| File | Line | Current Link | Should Be |
|---|---|---|---|
docs/platforms/python/integrations/celery/index.mdx |
346 | /guides/ |
/get-started/guides/ |
Each redirect hop loses ~15% of SEO link equity and adds latency for users.
4848da2 to
002fd22
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| - `message` **MUST** be a string containing at least one non-whitespace character. Missing, empty, and whitespace-only messages **MUST NOT** be sent. | ||
| - `message` **MUST NOT** exceed **4,096 Unicode code points**. Sentry validates Python string length with `len(message)`, which counts Unicode code points. SDKs **MUST** match this count for the value that will be sent, including any whitespace it retains. For well-formed Unicode, counting Unicode scalars produces the same result. Counting UTF-8 bytes, UTF-16 code units, or user-perceived characters (grapheme clusters) does not. | ||
| - If an `associated_event_id` is supplied, the SDK **MUST** validate that it is a UUID before sending it, unless the SDK's identifier type already guarantees this. | ||
| - SDKs **MUST** validate the final feedback payload after event processors and `beforeSendFeedback` have run, before enqueueing it for transport. Feedback that fails validation **MUST** be discarded, using the SDK's existing failure reporting conventions and the [client report guidance](#sdk-pipeline). |
There was a problem hiding this comment.
Bug: The internal link to the 'client report guidance' section is broken. The anchor #sdk-pipeline does not exist in the rendered documentation.
Severity: LOW
Suggested Fix
Update the link on line 89 in develop-docs/sdk/telemetry/feedbacks.mdx. Change the anchor from #sdk-pipeline to #spec-feedback-pipeline to correctly point to the 'SDK Pipeline' section. The updated link should be [client report guidance](#spec-feedback-pipeline).
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: develop-docs/sdk/telemetry/feedbacks.mdx#L89
Potential issue: In the documentation file `develop-docs/sdk/telemetry/feedbacks.mdx`,
the link `[client report guidance](#sdk-pipeline)` on line 89 is broken. The target
section, defined with `<SpecSection id="feedback-pipeline"...>`, is rendered with the
HTML ID `spec-feedback-pipeline`. The current anchor `#sdk-pipeline` does not point to
any existing element, which will prevent users from navigating to the correct section in
the rendered documentation.
Did we get this right? 👍 / 👎 to inform future reviews.
There was a problem hiding this comment.
The anchor link indeed does exist (https://develop-docs-git-philprime-user-feedback-validation.sentry.dev/sdk/telemetry/feedbacks/#sdk-pipeline)
3 participants
DESCRIBE YOUR PR
Add draft client-side validation requirements to the Feedback specification so SDKs catch input that Sentry would discard during ingestion. Clarify the 4,096-Unicode-code-point message limit, require validation after processors and callbacks, and specify accessible form errors that preserve input instead of silently truncating it. A live character counter remains optional.
The spec moves to 1.5.0, with the new section marked draft because existing SDKs do not yet implement the full contract. Source-linked findings distinguish Relay's shared context normalization budget from Sentry's message rejection limit and legacy-only name/email limits. They also document JavaScript's missing length checks and Java's UTF-16 truncation behavior. No SDK implementation changes are included.
Context: getsentry/sentry-cocoa#8973
IS YOUR CHANGE URGENT?
PRE-MERGE CHECKLIST