feat: Determine Electron process from minidump metadata #1049
+275
−49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in the above issue:
Rather than fully parse the minidumps as described in the above issue (ie. header + enumerate the streams), we just search for the
process_type
key in the minidump file and pick out the string that follows. This simplified approach is reasonable because Electrons Crashpad is configured to emit minimal minidumps (250-400kb).If we can't determine the process type from parsing the minidump, we have a new
event.process
tag ofunknown
. In most cases, these will be for child processes and I've added a test to confirm that if these are found at startup, they are correctly categorised.