Repository navigation
test(spring-boot): [Sample Tests 12] Move the Boot 4 Kafka test into the module - #6298
Draft
runningcode wants to merge 1 commit into
Draft
runningcode wants to merge 1 commit into
runningcode wants to merge 1 commit into
Conversation
📲 Install BuildsAndroid
|
This was referenced Oct 20, 2026
Draft
Draft
Draft
Draft
Draft
This was referenced Oct 20, 2026
Draft
Draft
Draft
Draft
runningcode
force-pushed
the
no/boot4-integration-test
branch
from
October 21, 2026 09:19
254e3ef to
37725db
Compare
runningcode
force-pushed
the
no/boot4-kafka-test
branch
from
October 21, 2026 09:19
b3db6af to
09a1818
Compare
Ports the Boot 4 sample's KafkaQueueSystemTest to the integrationTest suite with @embeddedkafka, as for Boot 3. Spring Boot 4 needs its Kafka starter for the auto-configuration, and spring-kafka-test comes from the Boot BOM like spring-kafka. The Boot 4 sample has no system tests left, so it comes off the system-test runner, the backend workflow and the Spring Boot 4 matrix. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
runningcode
force-pushed
the
no/boot4-integration-test
branch
from
October 21, 2026 11:27
37725db to
c8d0533
Compare
runningcode
force-pushed
the
no/boot4-kafka-test
branch
from
October 21, 2026 11:27
09a1818 to
adfe6cb
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Sample Tests)
main)📜 Description
Ports the Boot 4 sample's
KafkaQueueSystemTestto theintegrationTestsuite insentry-spring-boot-4, the same way as for Boot 3 in #6296. That was the sample's last system test, so this PR also takes the Boot 4 sample off the system-test runner and CI.@EmbeddedKafkaon the shared base class provides an in-JVM KRaft broker, so no Docker is needed.spring-boot-starter-kafka.spring-kafka-testcomes from the Boot BOM, likespring-kafka4.One thing to know: when the test JVM exits, the embedded Kafka 4 broker logs a
KafkaStorageExceptionfrom its own shutdown. Its scheduler threads still write checkpoints while it deletes its temporary directory. This happens after the tests have finished and doesn't affect results. Boot 3's Kafka 3.9 broker doesn't do it.💡 Motivation and Context
With this, the Boot 4 sample's system tests all run in-module, as the jakarta sample's do after #6296. The Boot 4 suite runs 25 tests.
💚 How did you test it?
:sentry-spring-boot-4:checkpasses.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Do the same for Boot 2 (
sentry-spring-boot).#skip-changelog