Repository navigation
feat(android): [Nav3 Lifecycle 3] Coordinate SentryNavEffect access to current IScope - #6305
Open
0xadam-brown wants to merge 3 commits into
Open
0xadam-brown wants to merge 3 commits into
0xadam-brown wants to merge 3 commits into
Conversation
Coordinate SentryNavEffect instances through the host lifecycle so overlapping navigation roots safely publish navigation state and tracing data.\n\nRefs JAVA-274
Contributor
|
This was referenced Oct 20, 2026
📲 Install BuildsAndroid
|
6 of 9 tasks
0xadam-brown
marked this pull request as ready for review
October 20, 2026 15:31
0xadam-brown
requested review from
adinauer,
markushi,
romtsn and
runningcode
as code owners
October 20, 2026 15:31
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Nav3 Lifecycle)
📜 Description
Introduce a new
CoordinatedBackStackObserverthat letsSentryNavEffectmake use of the state coordination code we added to.navigation3.lifecycle.Each effect now stages nav data through the lease-aware
NavScopeslayer and only publishes it while its navigation root owns the lease to the shared SentryIScope.💡 Motivation and Context
Applications can host more than one Navigation 3 root at a time. Lifecycle coordination prevents an inactive root from clearing or overwriting the active root's navigation state.
addresses: JAVA-274
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
The next PR adds lifecycle integration coverage for overlapping Activities, Fragments, and ViewPager pages.