Skip to content

feat(usagestats): Show count client outcomes for logs and metrics - #128335

Draft
Lms24 wants to merge 1 commit into
masterfrom
lms/feat-stats-usage-logs-metrics-count-outcomes
Draft

Lms24 wants to merge 1 commit into
masterfrom
lms/feat-stats-usage-logs-metrics-count-outcomes

Conversation

@Lms24

@Lms24 Lms24 commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

For now an experiment but pending getsentry/sentry-docs#20124, we should visualize count outcomes of client-side discarded logs and metrics in addition to size outcomes. The main reason being that not all SDKs will send byte outcomes due to the performance costs of calculating log/metric size for something that gets discarded anyway.

Show both outcomes when size outcomes are available:
image

Show only counts when no size outcomes are available:
image

Open issue: For the "only count outcomes" case, the Y-axis on the chart would primarily remain in bytes because we do have size information from server outcomes (which is good). This means, the client part's Y axis part is skewed and likely too small in comparison. A simple solution for this would be to multiply just the y axis part by an estimated average size but I didn't do this yet. Another solution would be plotting the count outcomes on a separate bar, but this could be quite confusing and make the chart less readable.

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📊 Type Coverage Diff

Metric Before After Delta
Coverage 95.77% 95.77% ±0%
Typed 141,860 141,883 🟢 +23
Untyped 6,271 6,274 🔴 +3
🔍 2 new type safety issues introduced

Non-null assertions (!) (2 new)

File Line Detail
static/app/views/organizationStats/mapSeriesToChart.ts 224 clientDiscardCounts[i]!
static/app/views/organizationStats/mapSeriesToChart.ts 267 clientDiscardCounts[i]!

This is informational only and does not block the PR.

This branch was successfully deployed

1 active deployment
Preview — b0c01bbe Deployed Oct 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant