Repository navigation
Conversation
Contributor
📊 Type Coverage Diff
🔍 2 new type safety issues introducedNon-null assertions (
This is informational only and does not block the PR. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now an experiment but pending getsentry/sentry-docs#20124, we should visualize count outcomes of client-side discarded logs and metrics in addition to size outcomes. The main reason being that not all SDKs will send byte outcomes due to the performance costs of calculating log/metric size for something that gets discarded anyway.
Show both outcomes when size outcomes are available:

Show only counts when no size outcomes are available:

Open issue: For the "only count outcomes" case, the Y-axis on the chart would primarily remain in bytes because we do have size information from server outcomes (which is good). This means, the client part's Y axis part is skewed and likely too small in comparison. A simple solution for this would be to multiply just the y axis part by an estimated average size but I didn't do this yet. Another solution would be plotting the count outcomes on a separate bar, but this could be quite confusing and make the chart less readable.