Skip to content

Commit

Permalink
ref(consumers): Remove ErrorsProcessor (#6711)
Browse files Browse the repository at this point in the history
This processor has been implemented in
rust_snuba/src/processors/errors.rs for quite a while now, and deployed
in US region since then. The python one should no longer be needed.

* Fix a user-facing bug where HTTP referers were no longer searchable,
as the `http_referer` column would always hold an empty string. The new
behavior is that any HTTP header like `Referer` or `Referrer` would be
used.
* Apparently the rust processor uses different hyphenization in
`contexts[trace_id]` than the python one. nobody noticed this as we use
a top-level trace_id column.
  • Loading branch information
untitaker authored Jan 7, 2025
1 parent f708511 commit 857a9fe
Show file tree
Hide file tree
Showing 4 changed files with 31 additions and 488 deletions.
2 changes: 1 addition & 1 deletion rust_snuba/src/processors/errors.rs
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,7 @@ impl ErrorRow {
.into_iter()
.flatten()
{
if key == "Referrer" {
if key == "Referer" || key == "Referrer" {
http_referer = value.0;
break;
}
Expand Down
Loading

0 comments on commit 857a9fe

Please sign in to comment.