Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(wip) Remove hardcoded references to eap_spans in EAP RPCs #6702

Closed
wants to merge 1 commit into from

Conversation

colin-sentry
Copy link
Member

Continuation of #6701

PR is to make sure tests still pass

Copy link

codecov bot commented Dec 30, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
2715 1 2714 6
View the top 1 failed tests by shortest run time
tests.web.rpc.test_common.TestCommon::test_expression_trace_id
Stack Traces | 0.002s run time
Traceback (most recent call last):
  File ".../web/rpc/test_common.py", line 11, in test_expression_trace_id
    assert attribute_key_to_expression(
AssertionError: assert attr_str['sentry.trace_id'] AS `sentry.trace_id_TYPE_STRING` == CAST(\n  trace_id,\n  'String'\n) AS `sentry.trace_id_TYPE_STRING`
  Full diff:
  + attr_str['sentry.trace_id'] AS `sentry.trace_id_TYPE_STRING`
  - CAST(
  -   trace_id,
  -   'String'
  - ) AS `sentry.trace_id_TYPE_STRING`

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@colin-sentry colin-sentry changed the base branch from master to eap_entity_2 January 7, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant