fix(ci): Enable third-party contributions #6721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should probably adopt https://docs.docker.com/build/ci/github-actions/share-image-jobs/ instead of using USERNAME/snuba-ci |
onkar
approved these changes
Jan 7, 2025
|
I noticed that the artifacts are published in |
|
@onkar I was mostly following the linked docker tutorial, I think saving to /tmp is just an intermediate step because github artifacts can only load/save on the filesystem. |
untitaker
added a commit
that referenced
this pull request
Jan 8, 2025
followup to #6721 It seems that by using `outputs:` in the previous step, we don't load the image into docker but _only_ into the local filesystem. this breaks docker push on master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we have had two external contributions recently:
neither of the contributors can iterate properly on their changes because our CI is actually busted for PRs launched from forks