Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Submission: LNbits Holesail Proxy #2007

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

oren-z0
Copy link
Contributor

@oren-z0 oren-z0 commented Jan 4, 2025

App Submission

I want to mention that I'm not part of either https://lnbits.com or https://holesail.io . I just found Holesail as a very useful way to connect to my LNbits remotely even if it runs behind NAT - without the overhead of TOR.

Notice the first commit that makes changes to the LNbits app submission in order to expose its port to the holesail proxy.
Since LNbits work on port 3007, I think it would be nice if the proxy worked on port 3107 (and likewise, if we implement similar proxies for other apps, we could have the proxy management port number to be the app port number + 100).
LNbits should also have a fixed ip address, exposed to the proxy.

App name

LNbits Holesail Proxy

256x256 SVG icon

I only have a png for the holesail.io logo. I think a good icon would combine the logos of LNbits and Holesail like this:
logo

Gallery images

Screenshot 2025-01-04 at 2 33 12
Screenshot 2025-01-04 at 2 33 27
Screenshot 2025-01-04 at 2 33 31
Screenshot 2025-01-04 at 2 31 14

I have tested my app on:

  • umbrelOS on a Raspberry Pi
  • umbrelOS on an Umbrel Home
  • [v] umbrelOS on Linux VM

@oren-z0 oren-z0 force-pushed the lnbits-holesail-proxy branch from 6743087 to 16a8569 Compare January 4, 2025 00:56
@oren-z0 oren-z0 force-pushed the lnbits-holesail-proxy branch from 16a8569 to a0c8d81 Compare January 4, 2025 00:58
Copy link

github-actions bot commented Jan 4, 2025

🎉   Linting finished with no errors or warnings   🎉

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

Please review the linting results below and make any necessary changes to your submission.

Linting Results

Severity File Description
ℹ️ lnbits-holesail-proxy/docker-compose.yml Potentially using unsafe user in service "web":
The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.
ℹ️ lnbits/docker-compose.yml Potentially using unsafe user in service "web":
The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.

Legend

Symbol Description
Error: This must be resolved before this PR can be merged.
⚠️ Warning: This is highly encouraged to be resolved, but is not strictly mandatory.
ℹ️ Info: This is just for your information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant