Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new fxn cromwell_labels #45

Merged
merged 7 commits into from
Aug 8, 2024
Merged

new fxn cromwell_labels #45

merged 7 commits into from
Aug 8, 2024

Conversation

sckott
Copy link
Member

@sckott sckott commented Aug 6, 2024

fix #43

@tefirman This is a PR from dev to main to cut a new release (v3.2.4)

The only feature here is the new function cromwell_labels that hits the /labels route in the Cromwell REST API.

This change was motivated to be able to display user provided labels in the shiny cromwell app FredHutch/shiny-cromwell#117

sckott added 6 commits July 26, 2024 12:44
- and add tests and fixtures for cromwell_labels
- and change handling of labels data in the post request for cromwell_submit_batch, post from a file rather than data
@sckott sckott added this to the rcromwell v3.2.4 milestone Aug 6, 2024
@sckott sckott requested a review from tefirman August 6, 2024 20:19
Copy link
Member

@tefirman tefirman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my end, looks awesome, thanks for adding this @sckott !

@tefirman tefirman merged commit 87d1266 into main Aug 8, 2024
7 checks passed
@sckott
Copy link
Member Author

sckott commented Aug 8, 2024

Great, thanks

@sckott sckott added medium priority Important but not urgent, implement soon v1.1 Should be implemented in PROOF v1.1 labels Aug 8, 2024
@tefirman tefirman mentioned this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium priority Important but not urgent, implement soon v1.1 Should be implemented in PROOF v1.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a labels function
2 participants