fix(Camera.tsx): processor calling stale worklet and callback #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a huge bug when depending on state values inside the callback of the frameProcessor. As the frameProcessor had an empty dependency array it always called a stale function identity callback of the worklet which got passed initially. I.E onCallback calls a function which holds an if clause which depends on a useState value it has never seen the new useState value if it changed as the new identity/recreated callback function would not be used inside the Worklet and frameProcessor
|
Hello @tastydev . Thanks for your support of the package, but I can't merge it now, I'll do a review later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a huge bug when depending on state values inside the callback of the frameProcessor. As the frameProcessor had an empty dependency array it always called a stale function identity callback of the worklet which got passed initially.
I.E callback prop calls a function which holds an if clause which depends on a useState value, it has never seen the new useState value if it changed as the new identity/recreated callback function would not be used inside the worklet and frameProcessor.
This fix is important to prevent confusion. I had to debug it for 4 hrs :P