-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Do not merge] Deprecate CodeQL Action v2 #2677
base: main
Are you sure you want to change the base?
Changes from 4 commits
a06dbc6
04b5afa
913d605
4541c13
66f5682
03d5731
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
OLDEST_SUPPORTED_MAJOR_VERSION=2 | ||
OLDEST_SUPPORTED_MAJOR_VERSION=3 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -63,27 +63,18 @@ For compiled languages: | |
The following versions of the CodeQL Action are currently supported: | ||
|
||
- v3 (latest) | ||
- v2 (deprecated, support will end on December 5th, 2024) | ||
|
||
The only difference between CodeQL Action v2 and v3 is the version of Node.js on which they run. CodeQL Action v3 runs on Node 20, while CodeQL Action v2 runs on Node 16. | ||
|
||
To provide the best experience to customers using older versions of GitHub Enterprise Server, we will continue to release CodeQL Action v2 so that these customers can continue to run the latest version of CodeQL as long as their version of GitHub Enterprise Server is supported. For example CodeQL Action v3.22.11 was the first release of CodeQL Action v3 and is functionally identical to v2.22.11. This approach provides an easy way to track exactly which features are included in different versions by looking at the minor and patch version numbers. | ||
|
||
For more information, see "[Code scanning: deprecation of CodeQL Action v2](https://github.blog/changelog/2024-01-12-code-scanning-deprecation-of-codeql-action-v2/)." | ||
Comment on lines
-66
to
-72
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same thing here as with the changelog note. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
|
||
## Supported versions of the CodeQL Bundle on GitHub Enterprise Server | ||
|
||
We typically release new minor versions of the CodeQL Action and Bundle when a new minor version of GitHub Enterprise Server (GHES) is released. When a version of GHES is deprecated, the CodeQL Action and Bundle releases that shipped with it are deprecated as well. | ||
|
||
| Minimum CodeQL Action | Minimum CodeQL Bundle Version | GitHub Environment | Notes | | ||
|-----------------------|-------------------------------|--------------------|-------| | ||
| `v3.26.6` | `2.18.4` | Enterprise Server 3.15 | | | ||
| `v3.26.6` | `2.18.4` | Enterprise Server 3.15 | | | ||
| `v3.25.11` | `2.17.6` | Enterprise Server 3.14 | | | ||
| `v3.24.11` | `2.16.6` | Enterprise Server 3.13 | | | ||
| `v3.22.12` | `2.15.5` | Enterprise Server 3.12 | | | ||
|
||
CodeQL Action v2 has stopped receiving updates now that GHES 3.11 is deprecated. | ||
|
||
See the full list of GHES release and deprecation dates at [GitHub Enterprise Server releases](https://docs.github.com/en/enterprise-server/admin/all-releases#releases-of-github-enterprise-server). | ||
|
||
## Troubleshooting | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Large diffs are not rendered by default.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add this paragraph to the relevant location in
CONTRIBUTING.md
as a reminder to add it back when we introduce v4?Or instead of copying this text directly, include a link to this text so that it can be easily found again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done — I actually linked to the specific docs diff in this PR; thought that would be easiest for someone to read and find the link to!