Rust: update rust-analyzer #18443
Draft
Rust: update rust-analyzer #18443
+745
−607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redsun82
force-pushed
the
redsun82/cargo-upgrade
branch
from
09f1027 to
c7a9889
Compare
There was a problem hiding this comment.
Copilot reviewed 30 out of 50 changed files in this pull request and generated no comments.
Files not reviewed (20)
- MODULE.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.ra-ap-rustc_abi-0.87.0.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.ra-ap-rustc_index-0.87.0.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.ra-ap-rustc_index_macros-0.87.0.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.ra-ap-rustc_lexer-0.87.0.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.ra-ap-rustc_parse_format-0.87.0.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.ra-ap-rustc_pattern_analysis-0.87.0.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.ra_ap_base_db-0.0.257.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.ra_ap_cfg-0.0.257.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.ra_ap_edition-0.0.257.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.ra_ap_hir-0.0.257.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.ra_ap_hir_def-0.0.257.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.ra_ap_hir_expand-0.0.257.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.ra_ap_hir_ty-0.0.257.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.ra_ap_ide_db-0.0.257.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.ra_ap_intern-0.0.257.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.ra_ap_limit-0.0.257.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.ra_ap_load-cargo-0.0.257.bazel: Language not supported
- misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.ra_ap_mbe-0.0.257.bazel: Language not supported
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
added 2 commits
January 9, 2025 15:34
Rust-analyzer turned out to be quite picky about paths, where `//?/`-prefixed paths can lead to flaky failures. See rust-lang/rust-analyzer#18894 for details. This makes paths always be canonicalized with `dunce`. Previously, `dunce` was used as a fallback, but that stopped working somewhere after version 0.0.248 of rust-analyzer.
redsun82
force-pushed
the
redsun82/cargo-upgrade
branch
from
a0516ef to
4f79199
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the result of
cargo-edit:rust.ungram(as the change was done upstream)ast-generatorfile_to_module_defnot working any more on Windows, by usingdunce::canonicalizeinstead ofstd::fs::canonicalize(see Regression:
Semantics::file_to_module_defsometimes returns no result on Windows DOS device paths rust-lang/rust-analyzer#18894 for details).