Skip to content

Prevent CI Doctor updater from exhausting its budget without saving progress - #11560

Merged
lpcox merged 2 commits into
mainfrom
copilot/aw-ci-updater-fix-incomplete-result
Nov 13, 2026
Merged

lpcox merged 2 commits into
mainfrom
copilot/aw-ci-updater-fix-incomplete-result

Conversation

@lpcox

@lpcox lpcox commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

The CI Doctor updater reported an incomplete result after triaging 50 candidates without saving receipts or producing a validated proposal. Integrity-filtered PR evidence and unauthenticated CLI calls also blocked completion.

  • Evidence access: Scope authenticated MCP reads to AWF, gh-aw, and mcpg, including unapproved content treated strictly as untrusted evidence. Retain read-only permissions and publishing restrictions.
  • Durable progress: Save receipts after each review; keep missing evidence pending rather than retrying through alternate credentials or transports.
  • Completion budget: Cap research at 15 minutes, reserving time for validation and a bounded proposal. Preserve explicit incomplete reporting.
  • Workflow contract: Regenerate the lock and add regression coverage for access scope, checkpointing, and completion requirements.

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
@lpcox lpcox changed the title [WIP] Fix CI and Integration Doctor Updater reported incomplete result Prevent CI Doctor updater from exhausting its budget without saving progress Nov 13, 2026
@lpcox
lpcox marked this pull request as ready for review November 13, 2026 23:45
Copilot AI dynamic review requested due to automatic review settings November 13, 2026 23:45
@lpcox
lpcox merged commit a7a2bca into main Nov 13, 2026
3 of 4 checks passed
@lpcox
lpcox deleted the copilot/aw-ci-updater-fix-incomplete-result branch November 13, 2026 23:55
@arianegirtz99-hue

arianegirtz99-hue commented Nov 13, 2026 via email

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The quarantine pattern can match benign cached PR titles and delete entire progress files, resetting cursors or losing completed reviews.

1 open issue
What changed in this PR

Updates AWF’s CI and Integration Doctor maintenance workflow to preserve review progress and reserve time for validated proposals, addressing the incomplete run reported in #11559.

Changes:

  • Scopes authenticated GitHub evidence reads to AWF, gh-aw, and mcpg while treating returned content as untrusted.
  • Requires immediate review receipts, a 15-minute research cap, validation, and explicit incomplete reporting.
  • Regenerates the workflow lock and adds regression checks for these requirements.
File Description
scripts/​ci/​diagnosis-maintenance-workflow.test.ts Adds access-scope, checkpointing, and completion contract checks.
.github/​workflows/​ci-integration-doctor-updater.md Defines evidence handling, durable progress, and bounded completion requirements.
.github/​workflows/​ci-integration-doctor-updater.lock.yml Applies access policies and regenerated runtime configuration.

Review effort: Max (dynamic)

# legitimate files (e.g. '## System Requirements', 'Override: false');
# also match the explicit '<system>' instruction tag.
INJECTION_PATTERN='^(New instruction:|SYSTEM:|Ignore (all |previous |prior )instructions?:|<system>)'
INJECTION_PATTERN='(^|[[:space:][:punct:]])(system|assistant|developer|user)[[:space:]]*:|^(New instruction:|Ignore (all |previous |prior )instructions?:|<system>)'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aw] CI and Integration Doctor Updater: reported incomplete result

4 participants