Skip to content

Use published AWF images for the firewall issue dispatcher - #11569

Merged
lpcox merged 4 commits into
mainfrom
copilot/aw-fix-firewall-driver-crash
Nov 14, 2026
Merged

lpcox merged 4 commits into
mainfrom
copilot/aw-fix-firewall-driver-crash

Conversation

@lpcox

@lpcox lpcox commented Nov 14, 2026 •

Copy link
Copy Markdown
Collaborator

The dispatcher failed before Copilot started because its AWF invocation combined a pinned image manifest with --build-local.

  • Configuration: Adds the dispatcher to the postprocessor’s published-release workflow list, preserving the compiler-selected AWF binary and images.
  • Regression coverage: Adds checks for the published-release path and the dispatcher lock’s image configuration.

The dispatcher lock still needs to be regenerated and postprocessed before the fix is complete.

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
@lpcox lpcox changed the title [WIP] Fix firewall issue dispatcher engine driver crash Use published AWF images for the firewall issue dispatcher Nov 14, 2026
@lpcox
lpcox marked this pull request as ready for review November 14, 2026 01:54
Copilot AI dynamic review requested due to automatic review settings November 14, 2026 01:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The checked-in dispatcher lock still combines --build-local with the pinned image manifest, leaving an incompatible configuration that fails the new lock assertions.

1 open issue
What changed in this PR

This PR updates AWF workflow postprocessing to preserve the firewall issue dispatcher’s compiler-selected release binary and images, addressing the configuration conflict reported in #11567.

Changes:

  • Adds the dispatcher to the published-release workflow list.
  • Adds regression checks for release preservation and the dispatcher lock’s image configuration.
File Description
scripts/​ci/​workflow-patches/​network-and-install.ts Adds the dispatcher to the published AWF preservation list.
scripts/​ci/​apply-general-workflow-patches.test.ts Adds dispatcher coverage and checks for pinned images without local-build overrides.

Review effort: Balanced (dynamic)

'ci-integration-doctor-updater.lock.yml',
'daily-agent-runtime-triage.lock.yml',
'doc-maintainer.lock.yml',
'firewall-issue-dispatcher.lock.yml',
@lpcox

lpcox commented Nov 14, 2026

Copy link
Copy Markdown
Collaborator Author

@copilot address review feedback

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

✅ Copilot review passed with no inline comments.

@lpcox Add the ready-for-aw label to this PR to trigger agentic CI smoke tests.

lpcox and others added 2 commits November 14, 2026 02:03
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

Copilot AI commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

@copilot address review feedback

Addressed in c5d033d (cleanup: fbafddb). Regenerated the dispatcher lock with gh-aw v1.2.3 and ran postprocessing. It now uses the published AWF v0.29.12 binary and pinned images without --build-local. Build and all 57 targeted tests passed; secret scanning and CodeQL found no issues.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Coverage Check Passed

Overall Coverage

Metric Base PR Delta
Lines 93.91% 93.92% 📈 +0.01%
Statements 92.47% 92.49% 📈 +0.02%
Functions 93.10% 93.14% 📈 +0.04%
Branches 86.87% 86.88% ➡️ +0.01%
📁 Per-file Coverage Changes (2 files)
File Lines (Before → After) Statements (Before → After)
src/routing/bootstrap.ts 90.0% → 91.0% (+1.00%) 85.2% → 86.5% (+1.34%)
src/nvx/one-shot-process.ts 81.5% → 84.0% (+2.47%) 74.7% → 76.8% (+2.11%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

@lpcox
lpcox merged commit 37b07db into main Nov 14, 2026
36 of 37 checks passed
@lpcox
lpcox deleted the copilot/aw-fix-firewall-driver-crash branch November 14, 2026 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aw] Firewall Issue Dispatcher: engine driver crashed

3 participants