Skip to content

[deep-report] Extract shared NetworkLogEntry base for AccessLogEntry/FirewallLogEntry/AuditLogEntry #54531

Closed as not planned

Description

@github-actions

Description

Three independently-parsed "one network request line" structs in pkg/cli overlap heavily but disagree on types: AccessLogEntry (access_log.go:21: Timestamp, Duration, ClientIP, Status, Size, Method, URL, User, Hierarchy, Type — all string), FirewallLogEntry (firewall_log.go:118: Timestamp, ClientIPPort, Domain, DestIPPort, Proto, Method, Status, Decision, URL, UserAgent — all string), and AuditLogEntry (firewall_policy.go:50: Schema, Client, Host, Dest, Method — string, Status int, Decision, URL). Status is string in two structs and int in the third, and ClientIP/ClientIPPort/Client name the same concept three different ways. Verified live at all cited locations.

Expected Impact

Removes type inconsistency (string vs int Status) across three near-identical "network log line" records, following the AnalysisBase/FirewallSummaryBase embedding pattern the same files already use one level up.

Suggested Agent

Copilot coding agent — extract a common NetworkLogEntry base struct and embed it in all three, normalizing Status to one type.

Estimated Effort

Medium (2-3 hours)

Data Source

DeepReport analysis, 2026-08-21 cycle, sourced from discussion #54506 (Typist - Go Type Consistency Analysis), Cluster 2. No existing open issue found covering this specific duplication.

Generated by 🔬 Deep Report · agent · 186.6 AIC · ⌖ 14.7 AIC · ⊞ 11.9K · ◷

  • expires on Aug 23, 2026, 4:35 AM UTC-08:00

Activity

  1. linked a pull request that will close this issueExtract shared network log entry base #54840on Aug 22, 2026
  2. github-actions commented on Aug 22, 2026

    @github-actions
    ContributorAuthor

    🍪 Issue Monster selected this for Copilot

    I've identified this issue as a good candidate for automated resolution and requested assignment to the Copilot coding agent.

    If assignment succeeds, the Copilot coding agent will analyze the issue and create a pull request with the fix.

    Om nom nom! 🍪

    🍪 Om nom nom by Issue Monster · gpt54 · 3.08 AIC · ⌖ 9.91 AIC · ⊞ 8.9K · ◷

  3. github-actions commented on Aug 23, 2026

    @github-actions
    ContributorAuthor

    This issue was automatically closed because it expired on 2026-08-23T12:35:18.949Z.

    Closed by Workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions