Skip to content

Integrate delivery and adoption lifecycle reporting - #78658

Merged
mnkiefer merged 19 commits into
mainfrom
mnkiefer-delivery-adoption-lifecycle
Nov 17, 2026
Merged

mnkiefer merged 19 commits into
mainfrom
mnkiefer-delivery-adoption-lifecycle

Conversation

@mnkiefer

Copy link
Copy Markdown
Collaborator

Summary

Bring delivery and adoption into existing gh-aw machinery rather than a separate generic reporting feature or CAO service.

  • Add shared lifecycle semantics and evidence retention for logs, audit, episodes, experiments, and MCP consumers. Keep verified human adoption distinct from explicit delivery-time fallback; infrastructure is not repository value.
  • Replace outcome-named public flags, JSON fields, artifact/event names, and experiment references. Include a major changeset and migration documentation; no compatibility aliases.
  • Extend the existing Metrics Collector with deterministic discovery and retained-delivery reconciliation. Persist a separate repo-memory ledger and checkpoint, resume missed windows, retry unavailable evidence, and publish metrics/lifecycle.json for existing performance reports. No new workflow or webhook dependency.
  • Preserve effect selectors across cold restoration, bound API/time/storage work, and expose partial coverage and deferred checks instead of inventing decisions. Regenerate affected workflow locks and schemas.

Attributed value still requires declared measurements and attribution evidence. Snapshot survival is not proof of continuous survival across a measurement window.

Validation

  • make fmt and make build.
  • make recompile: all 368 workflows compiled; make check-workflow-drift passed.
  • go test ./pkg/lifecycle ./pkg/cli -run 'Lifecycle|RetainedAdoption|RetainedLifecycle|LogsOutcome|CountLimitedLogsTargetResult|BuildContinuationIfNeeded' -count=1 passed.
  • In actions/setup/js, npm test -- --run collect_lifecycle.test.cjs metrics_collector_workflow.test.cjs prepare_objective_impact_lifecycle.test.cjs: 84 tests passed, including typecheck and session-schema freshness. Git signing was disabled only for temporary fixture repositories.
  • golangci-lint run ./pkg/cli ./pkg/lifecycle: zero issues. The change-scoped compile/vet and JavaScript-lint gate passed.
  • Read-only trials used four completed workflows without dispatching anything. Cold restoration preserved all 10 delivery identities and execution selectors; eight value-eligible records refreshed, with one verified human acceptance, six delivery-time fallbacks, and one pending proposal. The remaining two records were infrastructure. Production collector persistence and idempotent replay were also checked; a separate bounded discovery trial processed 41 real runs.

Validation limitation and operational bounds

The full make agent-report-progress gate is not green because custom lint reports pre-existing findings on unchanged lines. The current increment's remaining touched-file finding is the discarded GetCurrentRepoSlug() error in pkg/cli/logs_report.go, also present in baseline a6b4c9240c. Newly introduced lint findings were fixed; unrelated lint debt was left unchanged.

Initial discovery covers the previous day, not all historical deliveries. Older evidence and late reruns outside creation windows require a delivery backfill. Collection and provider refresh are bounded and checkpointed, so due records are not guaranteed a daily refresh; consumers must honor coverage, deferred work, and discovery watermarks. Unsupported provider observations remain unknown.

Follows the lifecycle work discussed after #78452.

mnkiefer and others added 10 commits November 16, 2026 18:22
Migrate the reserved operational-value evaluator to the restricted JavaScript lane while preserving ordered metric compatibility and legacy Bash deprecation support.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
# Conflicts:
#	.github/workflows/dependabot-burner.lock.yml
#	docs/src/content/docs/reference/workflow-linters.md
#	scripts/dependabot-burner-selection.test.cjs

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
# Conflicts:
#	.github/workflows/dependabot-burner.lock.yml

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Share versioned lifecycle rules, execution evidence, provider observations and retained identities across logs, audit, episodes, experiments and MCP. Migrate workflow consumers and public contracts without legacy aliases; keep attributed value separate from delivery and adoption.

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Persist delivery identities and discovery checkpoints in separate repo-memory. Refresh older adoption through the shared logs evaluator, resume missed collection windows, and publish bounded lifecycle snapshots for existing reports.

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI adaptive review requested due to automatic review settings November 17, 2026 06:39
@mnkiefer
mnkiefer marked this pull request as draft November 17, 2026 06:39

This comment was marked as outdated.

@mnkiefer

Copy link
Copy Markdown
Collaborator Author

@copilot Fix the code for all comments in this review thread.

When a review comment includes a suggested change, apply the suggestion exactly.

Do not make changes beyond what is described in the linked review thread.

Both delivery and adoption exist. They are different things.

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

Copilot AI commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

@copilot Fix the code for all comments in this review thread.

When a review comment includes a suggested change, apply the s...

Updated the test to expect the registered delivery artifact-set name; adoption remains distinct. Committed as 0539782e.

mnkiefer and others added 2 commits November 17, 2026 07:45
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
@mnkiefer
mnkiefer marked this pull request as ready for review November 17, 2026 08:12
@mnkiefer

Copy link
Copy Markdown
Collaborator Author

@copilot resolve the merge conflicts in this pull request

@mnkiefer

Copy link
Copy Markdown
Collaborator Author

@copilot resolve the merge conflicts in this pull request

…ption-lifecycle

# Conflicts:
#	.github/aw/instructions.md
#	.github/aw/intent.md
#	.github/skills/operational-value-designer/SKILL.md
#	.github/workflows/daily-harness-experiment-proposer.lock.yml
#	.github/workflows/dependabot-burner.lock.yml
#	.github/workflows/metrics-collector.lock.yml
#	actions/setup/js/child_process_timeouts.cjs
#	docs/src/content/docs/experimental/trace-graders.md
#	docs/src/content/docs/specs/graders-specification.md
#	docs/src/content/docs/specs/unified-agent-session-specification.md
#	scripts/dependabot-burner-selection.test.cjs

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

Copilot AI commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

The merge is already resolved in commit f3ca1f8, which has main as its second parent. I refreshed origin/main and confirmed it is an ancestor of the PR branch; the worktree is clean and there are no unresolved conflicts.

@mnkiefer

Copy link
Copy Markdown
Collaborator Author

@copilot Fix failing checks

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

Copilot AI commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

@copilot Fix failing checks

Fixed in 3fb6306. The targeted JavaScript, connector, workflow-golden, and cached-log tests pass. The final local gate only remains nonzero for existing custom Go lint findings on unchanged lines; I did not trigger CI.

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot

🍳 A little prep to help this PR along! Copilot assignment requested for the following outstanding work:

  1. Update this branch with the latest main using make merge-main, resolving any conflicts and preserving the intended changes.
  2. Fix failing check impacted-go-tests (FAILURE): Check run.

Keeping the changes focused; human review and CI get the final taste test. No merging or CI triggering.

Structured data
{
  "completed_task": 0,
  "head": "3fb6306a26e6ca48de00521ade6e716766496dd7",
  "kind": "requested",
  "schema_version": "1",
  "state": "7928a9c49df5bf53dba605f11782c762c73a0a7254c27fbca30785bc5599465c",
  "work": [
    "42e5d572d9d75b7168fe7d0aeda0717cc07e65ed240f6d299e6fec661214f1ac"
  ],
  "workflow": "pr-sous-chef"
}

Generated by 👨🍳 PR Sous Chef · pi · routed: haiku55 xhigh · ~2 AIC · ⌖ ~2 AIC · ⊞ 7K · ◷
Comment /souschef to run again

gh-aw-bot and others added 2 commits November 17, 2026 09:53
…ption-lifecycle

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

Copilot AI commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Merge conflicts were resolved in f3ca1f8. The latest main update is also merged cleanly in bfbc841.

@copilot resolve the merge conflicts in this pull request

Merge conflicts were resolved in f3ca1f8. The latest main update is also merged cleanly in bfbc841.

@copilot

🍳 A little prep to help this PR along! Copilot assignment requested for the following outstanding work:...

Merged latest main via make merge-main in bfbc841 and fixed the impacted Go test in e7e7b07 by updating stale schema-version fixtures. The focused tests pass; the final validation gate is still running.

mnkiefer and others added 2 commits November 17, 2026 11:24
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@mnkiefer
mnkiefer merged commit 892f361 into main Nov 17, 2026
97 of 99 checks passed
@mnkiefer
mnkiefer deleted the mnkiefer-delivery-adoption-lifecycle branch November 17, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants