Repository navigation
Conversation
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅
|
|
✅ Ponytail Reviewer completed successfully! Ponytail ReviewerOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ PR Code Quality Reviewer completed the code quality review. PR Code Quality ReviewerOutcome: The agent completed and reported one or more actions. The no-op output is a completion signal, not a claim that no action was taken. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ PR Specification Reviewer completed successfully! Caution agentic threat detected DetailsPotential security threats were detected in the agent output. Detected threat types: prompt injection. Review the workflow run logs for details. PR Specification ReviewerOutcome: The agent completed and reported one or more actions. The no-op output is a completion signal, not a claim that no action was taken. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ Test Quality Sentinel completed test quality analysis. Test Quality SentinelOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
There was a problem hiding this comment.
Caution
agentic threat detected
Threat detection flagged this output in warn mode. Manual review is REQUIRED before any follow-up automation.
Details
Potential security threats were detected in the agent output. Detected threat types: prompt injection.
Review the workflow run logs for details.
Overview
Reviewed PR head 430c17272cf34e6e6e23ad5cb6da77149d379fbf against the Unified Agent Session Specification (documented version 2.10.0; affected runtime-vocabulary contract T-UAS-061, with preservation requirements T-UAS-027/T-UAS-029 and publication safety T-UAS-049).
Finding
The new data.execution_trace contract is not synchronized with the specification metadata: frontmatter/document metadata and the change log remain at 2.10.0, while the status section still says 2.8.0. Please update the version/date consistently, correct the stale status reference, and add a focused change-log entry for the bounded/redacted trace semantics. An inline comment marks the changed contract paragraph.
Coverage
Static review only; no tests or conformance scripts were run, per review contract.
Generated by PR Specification Reviewer for #78680 · copilot · gpt50 · ~8 AIC · ⌖ ~2 AIC · ⊞ 1.6K
Comment /review-specs to run again
Comment MemoryPeek at saved memory (pr-code-quality-reviewer)Note This comment is managed by comment memory.Expand the saved memory block to view or edit the persistent context for this thread.
|
There was a problem hiding this comment.
Found two actionable trace-accuracy issues: both handlers record the configured no-change mode at invocation start, so normal non-empty operations receive markers for branches they never take. Inline comments explain the impact and suggested placement. No blocking correctness or security issues found; this was a static diff review and tests were not run.
🔎 Code quality review by PR Code Quality Reviewer · copilot · gpt50 · ~7 AIC · ⌖ ~2 AIC · ⊞ 1.5K
Comment /review to run again
Comment MemoryPeek at saved memory (spec-review-history)History |
Comment MemoryPeek at saved memory (review-history)History |
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /diagnosing-bugs, /tdd and /codebase-design. Requesting changes because the execution trace can misreport the route a run actually took.
📋 Key Themes & Highlights
Key Themes
- Trace accuracy:
v/w(push) andQ(create PR) are recorded at handler entry from configuration, so they can mark routes the run never took. - Map drift: push handler
sis labelled "unchanged checkout" in the map, but the code marks the empty-patch skip. - Result leak:
execution_traceis enumerable and survives the result spreads insafe_output_handler_manager.cjs. - Test quality: one wiring assertion checks source text rather than behaviour.
Positive Highlights
- ✅ Clean per-invocation closure, so overlapping calls keep private traces.
- ✅ The wrapper order (trace outside transport integrity) lets the outer layer see converted failures.
- ✅ Trace letters are unique within each handler, and the map comments match the markers.
- ✅ Marker validation and the 1024-character bound are enforced both in the wrapper and in outcome projection.
Not Verified
The vitest suites, npm run typecheck, and npm run schema:session:check could not run in this environment: npm ci failed on the package proxy TLS certificate, and the schema generator needs ts-json-schema-generator. The schema JSON parses and the new module passes a syntax check. Please run the test and schema gates in CI before merging.
@copilot please address the review comments above.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · copilot · routed: haiku55 xhigh · ~14 AIC · ⌖ ~2 AIC · ⊞ 6.6K
Comment /matt to run again
There was a problem hiding this comment.
🟡 Changes recommended
Appending tracing after variable handler arguments can place temporaryIdMap in the trace callback’s position, causing handlers invoked by processMessages to throw.
2 open issues
What changed in this PR
Adds compact execution-path tracing to gh-aw’s pull-request safe outputs so operators can analyze handler routes in unified sessions.
Changes:
- Instruments pull-request creation and branch pushes with branch and terminal-outcome markers.
- Adds invocation-local tracing capped at 1,024 characters.
- Persists traces across outcome types and retries, with schema, documentation, and test updates.
| File | Description |
|---|---|
docs/src/content/docs/specs/unified-agent-session-specification.md |
Documents trace format, persistence, and revision-aware interpretation. |
docs/public/schemas/unified-session.schema.json |
Defines and validates execution_trace fields. |
actions/setup/js/types/unified_session.d.ts |
Adds the optional typed trace field. |
actions/setup/js/safe_output_trace.test.cjs |
Tests isolation, bounds, identity preservation, wrappers, and marker uniqueness. |
actions/setup/js/safe_output_trace.cjs |
Implements bounded tracing and result/error attachment. |
actions/setup/js/safe_output_outcomes.test.cjs |
Tests trace persistence, validation, and retry outcomes. |
actions/setup/js/safe_output_outcomes.cjs |
Includes validated traces in projected outcomes. |
actions/setup/js/safe_output_handler_manager.cjs |
Retains traces from returned failures, exceptions, and retries. |
actions/setup/js/push_to_pull_request_branch.test.cjs |
Adds expected traces for push and recovery scenarios. |
actions/setup/js/push_to_pull_request_branch.cjs |
Instruments branch-push routes and documents marker meanings. |
actions/setup/js/create_pull_request.test.cjs |
Adds expected traces for creation and fallback scenarios. |
actions/setup/js/create_pull_request.cjs |
Instruments pull-request creation routes and documents marker meanings. |
Review effort: Max (adaptive)
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
🍳 A little prep to help this PR along! Copilot assignment requested for the following outstanding work:
Keeping the changes focused; human review and CI get the final taste test. No merging or CI triggering. Structured data{
"completed_task": 0,
"head": "ea0dd79daa6dac3addb218299a801fdcef7221f6",
"kind": "requested",
"schema_version": "1",
"state": "361e48e91a4940e10856b6c33fb407db0b2bafa2b62052fddd80b0486002d0cb",
"work": [],
"workflow": "pr-sous-chef"
}
|
…-pull-request-logging # Conflicts: # actions/setup/js/safe_output_handler_manager.cjs Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Merged the latest |


Add compact execution-path identifiers to
create-pull-requestandpush-to-pull-request-branch, enabling downstream operators to identify hot paths and problematic recovery routes in unified sessions.execution_traceacross successful, failed, skipped, staged, and retry outcomes.Example outcome fields:
{ "type": "push_to_pull_request_branch", "status": "success", "execution_trace": "AMTdefnux" }Identifiers describe paths, not invocations; interpret them against the operation type and handler source revision.