Repository navigation
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
🧠 Matt Pocock Skills Reviewer is reviewing this pull request using Matt Pocock's engineering skills... |
|
✅ Test Quality Sentinel completed test quality analysis. Test Quality SentinelOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ PR Code Quality Reviewer completed the code quality review. PR Code Quality ReviewerOutcome: The agent completed and reported one or more actions. The no-op output is a completion signal, not a claim that no action was taken. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ Ponytail Reviewer completed successfully! Ponytail ReviewerOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
Comment MemoryPeek at saved memory (pr-code-quality-reviewer)Note This comment is managed by comment memory.Expand the saved memory block to view or edit the persistent context for this thread.
|
There was a problem hiding this comment.
I found one blocking test-quality issue: the new regression suite uses a bespoke Astro config and therefore does not validate the production markdown pipeline or plugin ordering. Please make the tests exercise the production configuration (or otherwise cover that wiring) before merge.
🔎 Code quality review by PR Code Quality Reviewer · copilot · gpt50 · ~3 AIC · ⌖ ~1 AIC · ⊞ 1.5K
Comment /review to run again
| await mkdir(join(docsRoot, ".astro"), { recursive: true }); | ||
| root = await mkdtemp(join(docsRoot, ".astro/page-titles-")); | ||
| const content = join(root, "src/content/docs"); | ||
| await mkdir(content, { recursive: true }); |
There was a problem hiding this comment.
This regression suite builds a separate minimal Astro configuration instead of exercising docs/astro.config.mjs. As a result, it never runs the production remark plugins or the actual rehypeDeduplicateTitle + rehypeTableWrapper ordering, so a wiring/order regression in the real docs pipeline can pass all of these tests. Please either build with the production config (isolating only the fixture content) or add coverage that validates the production configuration itself.
There was a problem hiding this comment.
The fixture now uses the production Markdown processor and asserts the production table wrapper output. Committed as 49c548d.
Comment MemoryPeek at saved memory (review-history)History |
There was a problem hiding this comment.
🟡 Changes recommended
Title deduplication can remove a landing page’s only H1 and leave duplicate titles when an MDX comment precedes the opening heading.
2 open issues
What changed in this PR
This PR adds shared Astro title deduplication so documentation pages do not repeat their frontmatter title as an opening Markdown H1.
Changes:
- Adds a rendering plugin that compares normalized title text and preserves heading anchors.
- Adds production-rendered Markdown and MDX regression cases and documents the behavior.
- Adds sandbox guidance for worktrees, temporary caches, and external docs dependencies.
| File | Description |
|---|---|
docs/tests/page-titles.test.mjs |
Adds rendered title and anchor regression tests. |
docs/src/lib/rehype/deduplicateTitle.js |
Implements matching opening-title deduplication. |
docs/README.md |
Documents title behavior and the test command. |
docs/package.json |
Adds the test:titles script. |
docs/astro.config.mjs |
Registers the shared rendering plugin. |
AGENTS.md |
Adds sandbox-compatible command guidance. |
.github/skills/developer/SKILL.md |
Details worktree, cache, and dependency handling. |
Review effort: Balanced (adaptive)
| heading.tagName = "span"; | ||
| heading.children = []; |
There was a problem hiding this comment.
Deduplication now skips the root docs index.md/index.mdx; I added a Markdown landing-page H1 regression case. Committed as 49c548d.
| function isContent(node) { | ||
| if (node.type === "comment" || node.type === "mdxjsEsm") return false; | ||
| if ("value" in node && typeof node.value === "string") { | ||
| if (node.type === "text" && !node.value.trim()) return false; |
There was a problem hiding this comment.
Comment-only MDX flow expressions are now ignored, and the MDX fixture places such a comment before the matching H1. Committed as 49c548d.
|
🍳 A little prep to help this PR along! Copilot assignment requested for the following outstanding work:
Keeping the changes focused; human review and CI get the final taste test. No merging or CI triggering. Structured data{
"completed_task": 0,
"head": "cc8cf84918753fd2abcc8287c99b491712f17056",
"kind": "requested",
"schema_version": "1",
"state": "81d7de2602c4e195022fe3ce70bea2f848ac3ab891dd89e51ddd459821ced91f",
"work": [
"35c4c891f9dff635ed610abe02f021bc2117450d8ae8bf8d092685cf9b456cb0",
"43282e7f5b3023b8c8cf9099eab79e7b99f650965f08b47d3df33cde5589879d",
"4ca2671bb13933b4ac702a712dfd1adc8119559e8c7c2f60ca9e473cfde787af",
"5c4bd4c61b3573cfe13e822470eb1ceb829c77c170c1c3459dd613c915ff1df2"
],
"workflow": "pr-sous-chef"
}
|
…itles Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

Summary
Docs pages such as the Unified Agent Session Specification render the frontmatter title and the same opening Markdown heading twice. Deduplicate matching opening H1s in the shared Astro rendering pipeline instead of editing individual pages.
Validation
npm --prefix docs run test:titles: 23 production-rendered regression cases passed, including the reported specification page.python3 scripts/check-instruction-prefixes.py AGENTS.md .github/skills/developer/SKILL.mdpassed.make agent-report-progressand the finalmake agent-report-progress-no-testpassed.The full docs build was attempted but is blocked by missing external
githubnext/agenticsworkflow sources required by the existing build configuration.