Skip to content

update test - #968

Merged
tsusdere merged 1 commit into
masterfrom
update-tests
Nov 3, 2026
Merged

tsusdere merged 1 commit into
masterfrom
update-tests

Conversation

@tsusdere

@tsusdere tsusdere commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Why?

The test in our integration file is failing due to a mismatch in assertions and what is being rendered.

Fix

Update the assertion to now match the rendered attribute.

Copilot AI auto review requested due to automatic review settings November 3, 2026 21:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are present, and the test assertion now tolerates SVG attribute ordering while retaining checks for class and accessibility attributes.

No open issues 🎉

What changed in this PR

Updates the Octicons integration test to match the rendered SVG markup regardless of attribute ordering.

Changes:

  • Replaces the exact SVG height string assertion with an attribute-aware regular expression.
  • Preserves assertions for the SVG class and accessibility attributes.
File Description
spec/​github-pages/​integration_spec.rb Adjusts the Octicons SVG height assertion to reliably match the rendered markup.

Review effort: Lite (auto)

@tsusdere
tsusdere merged commit 38fbe00 into master Nov 3, 2026
11 checks passed
@tsusdere
tsusdere deleted the update-tests branch November 3, 2026 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants