Skip to content

test(package-feeds): assert the cargo branch of the package-manager wrapper #2357

Open

Description

@jamesadevine

Follow-up from the #2315 review.

wrapper_routes_only_its_own_process_and_carries_no_credential (src/compile/extensions/package_feeds.rs) asserts the npm, pip, and dotnet branches of the generated package-manager wrapper, but not cargo). That branch carries the most delicate settings:

  • CARGO_HTTP_PROXY and CARGO_HTTP_CAINFO (process-scoped proxy and trust bundle);
  • CARGO_CREDENTIAL_ALIAS_ADOAWPROXY plus CARGO_REGISTRY_GLOBAL_CREDENTIAL_PROVIDERS=adoawproxy.

Nothing checks that the Cargo token helper (PACKAGE_CARGO_TOKEN) renders only the non-secret ADO_MCP_TOKEN_SENTINEL.

Acceptance criteria

  • Slice-assert the cargo) case for all four variables.
  • Assert that the rendered token helper prints only the sentinel and references no credential variable.
  • Cargo is not exercised by the live smoke (there is no Cargo runtime), so these unit assertions are its main guard.

Activity

  1. github-actions commented on Oct 16, 2026

    @github-actions
    Contributor

    🏷️ Triaged

    Labeled as test, rust.

    Why: The issue asks for additional unit-test assertions on the cargo branch of the generated package-manager wrapper in src/compile/extensions/package_feeds.rs.

    Automated triage — a maintainer can adjust labels anytime.

    Generated by Issue Triage for #2357 · auto · 12.2 AIC · ⊞ 9.7K · ◷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    rustPull requests that update rust codetest

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions