Skip to content

fix(compile): decide how the package-config check treats symlinked config files #2360

Open

Description

@jamesadevine

Follow-up from the #2315 review (Rust reviewer, unposted theme).

package_config_check resolves the well-known config files at the repository root with std::fs::metadata, which follows symlinks. A symlinked nuget.config or .npmrc is therefore scanned at its target, which can be outside the repository.

Following the link matches what the package manager does at runtime, which is arguably the right behaviour for a check meant to predict runtime failures. But it means compile reads files outside the repo and can quote URLs from them in warnings.

Acceptance criteria

  • Choose and document one of:
    • (a) keep following symlinks, documented, with a test;
    • (b) follow only links that resolve inside the repository;
    • (c) skip symlinked config files with an advisory note.
  • Add a test for the chosen behaviour.

Activity

  1. github-actions commented on Oct 16, 2026

    @github-actions
    Contributor

    🏷️ Triaged

    Labeled as enhancement, rust, security.

    Why: Requests a design decision and test for how the compiler's package-config check handles symlinked config files. It concerns Rust compile code, and reading files outside the repo is security-relevant.

    Automated triage — a maintainer can adjust labels anytime.

    Generated by Issue Triage for #2360 · auto · 12.2 AIC · ⊞ 9.7K · ◷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestrustPull requests that update rust codesecurity

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions