Alternatives to committing #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`uploadArtifact` already prints a more detailed message.
Wattenberger
approved these changes
Aug 23, 2021
README.md
Outdated
|
|
||
| The maximum number of nested folders to show files within. A higher number will take longer to render. | ||
|
|
||
| Default: 9 | ||
|
|
||
| ## `commit_message` | ||
| ### `push` |
There was a problem hiding this comment.
do you mind renaming this to should_push, just for extra clarity?
README.md
Outdated
|
|
||
| Should be a boolean value, i.e. `true` or `false`. See `commit_message` and `branch` for how to customise the commit. | ||
|
|
||
| Default: `false` |
There was a problem hiding this comment.
we should probably leave this as true, for backwards compatibility, like you mentioned in your PR. I know there are projects using repo-visualizer@main
There was a problem hiding this comment.
Oops, the default was indeed true but I miswrote it in the README! Will fix it.
|
wonderful! thanks for the PR and quick updates! this is a great feature! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to address #16.
pushshould_pushthat lets you choose not to commit and push the diagram (true by default, to maintain current behaviour).Note sure if this is overkill, comments very welcome.