-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in ifconfig parsing #1
base: main
Are you sure you want to change the base?
Conversation
Thank you for this pull request. Does the ifconfig parsing still work on Ubuntu 16.04 after this change? |
Hmm, haven't tested on 16.04, this is pn 18.04 with Melodic |
I can possibly write it so that it takes either format |
If this is possible, this would be one option. The other option is, to provide two differents files net-statistics-18.04 and net-statistics-16.04 and update the documentation markdown file to tell the user to use the right one. I also noticed this issue when installing on Lubuntu 18.04 but I also had some additional issues to solve for 18.04. Therefore I thing the best solution would be to have a separate folder with the markdown file and the required files for different Linux versions. Therefore the headline is "URsim 5.10 Installation Guide for Ubuntu 16.04" because it is exactly for 16.04. |
Hmm, that's fair, I might update my fork to 18.04 documentation and keep it separate |
Thank you for your pull request, I hope, I can create a 18.04 documentation within the next days |
Make some minor modifications. Still need to flesh these out and correct mistakes
Output of ifconfig on ubuntu 18.04. Note
intet addr:
andMask:
do not exist.