Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in ifconfig parsing #1

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

ljden
Copy link

@ljden ljden commented May 12, 2021

Output of ifconfig on ubuntu 18.04. Note intet addr: and Mask: do not exist.

enp0s3: flags=4163<UP,BROADCAST,RUNNING,MULTICAST>  mtu 1500
        inet 10.0.2.15  netmask 255.255.255.0  broadcast 10.0.2.255
        inet6 fe80::a00:27ff:fe4c:eb1d  prefixlen 64  scopeid 0x20<link>
        ether 08:00:27:4c:eb:1d  txqueuelen 1000  (Ethernet)
        RX packets 0  bytes 0 (0.0 B)
        RX errors 0  dropped 0  overruns 0  frame 0
        TX packets 62  bytes 7089 (7.0 KB)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0

@githubuser0xFFFF
Copy link
Owner

Thank you for this pull request. Does the ifconfig parsing still work on Ubuntu 16.04 after this change?

@ljden
Copy link
Author

ljden commented May 12, 2021

Hmm, haven't tested on 16.04, this is pn 18.04 with Melodic

@ljden
Copy link
Author

ljden commented May 12, 2021

I can possibly write it so that it takes either format

@githubuser0xFFFF
Copy link
Owner

If this is possible, this would be one option. The other option is, to provide two differents files net-statistics-18.04 and net-statistics-16.04 and update the documentation markdown file to tell the user to use the right one.

I also noticed this issue when installing on Lubuntu 18.04 but I also had some additional issues to solve for 18.04. Therefore I thing the best solution would be to have a separate folder with the markdown file and the required files for different Linux versions. Therefore the headline is "URsim 5.10 Installation Guide for Ubuntu 16.04" because it is exactly for 16.04.

@ljden
Copy link
Author

ljden commented May 12, 2021

Hmm, that's fair, I might update my fork to 18.04 documentation and keep it separate

@githubuser0xFFFF
Copy link
Owner

Thank you for your pull request, I hope, I can create a 18.04 documentation within the next days

ljden added 4 commits May 13, 2021 12:06
Make some minor modifications. Still need to flesh these out and correct mistakes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants