Usability improvements (callback, options) #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 17, 2019 10:52
…e customization and handle resize events, added some examples
|
This option to handle the answer directly in the page as callback instead of redirecting really needs to be added. Its ridiculous that support for SPA setups isn't supported in 2019. |
|
What is the current status? Why this wasn't merged yet? |
|
@pesimeao Crazy huh? and this is nearly 1 year later. |
|
The callback option must be a feature, this is great work and hope it gets merged soon. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Added the ability to handle the answer directly in the page as callback instead of redirecting the viewer to another page.
*Added "autoload" feature so the user do not have to click on a button
*Added options/events to handle iframe resize and or more if needed
*added examples of the above and updated readme
TODO: handle failed attempts directly from modal/embedded instead of redirecting the user each time.
fix #23