Switch from flake8/yapf to ruff. #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaander
requested review from
a team,
tcmoore3 and
pepak13
and removed request for
a team
tcmoore3
approved these changes
Nov 14, 2023
| self.run(self.benchmark_steps) | ||
| performance.append(self.get_performance()) | ||
| if print_verbose_messages: | ||
| print(f'.. {performance[-1]} {self.units}') | ||
| else: | ||
| for i in range(self.repeat): | ||
| for _i in range(self.repeat): |
There was a problem hiding this comment.
Did ruff make this change? If so, should we let a formatter change variable names?
There was a problem hiding this comment.
Yes, it was one of the unsafe fixes that I explicitly opted into on the command line --unsafe-fixes and then carefully reviewed (https://docs.astral.sh/ruff/rules/unused-loop-control-variable/). Running pre-commit run will not make these changes.
This particular change solves https://docs.astral.sh/ruff/rules/unused-loop-control-variable/. I don't particularly agree with underscore prefixes as a solution to solve unused variables, but when switching to standard tools we are opting into what is considered the "standard" solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switch from flake8/yapf to ruff.
Motivation and context
Perform more lint checks and format in less time.
How has this been tested?
Local execution:
Checklist:
CONTRIBUTORS.md) in the pull request source branch.