-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move environment configuration to its own class #784
Conversation
Supports 3 node types: - shared: 1 node or less - mixed: any number of tasks - wholenode: whole node increments
Also move threshold to _PartitionConfig class and gpus_per_node default to 0.
Tested appropriate errors for GPU/non-GPU and node requests on Bridges2. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #784 +/- ##
==========================================
+ Coverage 69.41% 69.54% +0.13%
==========================================
Files 48 48
Lines 4407 4417 +10
Branches 1065 1069 +4
==========================================
+ Hits 3059 3072 +13
+ Misses 1140 1138 -2
+ Partials 208 207 -1 ☔ View full report in Codecov by Sentry. |
@cbkerr when you have a moment could you review? |
@cbkerr will you have time to review or should I assign someone else? |
@b-butler Thanks for the ping. I can get to this during the next few days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concerning documentation:
Are there any user-facing changes to the template and environment documentation we would need to add?
What are the risks of default values changing and messing up inherited values?
@cbkerr Nope, this is purely a developer facing thing currently. |
Needed since one of the ops is a GPU operation.
Description
Adds three classes
_PartitionConfig
: an environment's partition configuration_Partition
: a specific partition's data_NodeTypes
: what kind of nodes a partition supportsMotivation and Context
With recent changes to flow's template/submission logic (see #722), the environment classes were becoming loaded with class variables. This makes a logical change to storing the partition specific information in appropriate classes. This also removes some methods from the environments in favor of putting them in the partition classes.
Checklist: