Remove compatibility layers and other deprecated code #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
requested review from
bdice and
tommy-waltmann
and removed request for
a team
vyasr
force-pushed
the
remove_compat_layers
branch
from
9adefa7 to
ccf70e0
Compare
tommy-waltmann
approved these changes
May 2, 2022
bdice
approved these changes
May 3, 2022
This was referenced May 6, 2022
bdice
pushed a commit
that referenced
this pull request
Jun 14, 2022
* Remove doc filter support. * Remove support for workspace as function. * Remove backwards compatibility layer for project_names in init. * Remove backwards compat layers for schema. * Remove backwards compat layers in CLI. * Get all tests passing. * Fix style. * Update changelog. * Update changelog. * Address all PR comments except for renaming init_project parameter.
bdice
pushed a commit
that referenced
this pull request
Aug 1, 2022
* Remove doc filter support. * Remove support for workspace as function. * Remove backwards compatibility layer for project_names in init. * Remove backwards compat layers for schema. * Remove backwards compat layers in CLI. * Get all tests passing. * Fix style. * Update changelog. * Update changelog. * Address all PR comments except for renaming init_project parameter.
bdice
pushed a commit
that referenced
this pull request
Oct 7, 2022
* Remove doc filter support. * Remove support for workspace as function. * Remove backwards compatibility layer for project_names in init. * Remove backwards compat layers for schema. * Remove backwards compat layers in CLI. * Get all tests passing. * Fix style. * Update changelog. * Update changelog. * Address all PR comments except for renaming init_project parameter.
bdice
pushed a commit
that referenced
this pull request
Oct 27, 2022
* Remove doc filter support. * Remove support for workspace as function. * Remove backwards compatibility layer for project_names in init. * Remove backwards compat layers for schema. * Remove backwards compat layers in CLI. * Get all tests passing. * Fix style. * Update changelog. * Update changelog. * Address all PR comments except for renaming init_project parameter.
vyasr
added a commit
that referenced
this pull request
Oct 30, 2022
* Remove doc filter support. * Remove support for workspace as function. * Remove backwards compatibility layer for project_names in init. * Remove backwards compat layers for schema. * Remove backwards compat layers in CLI. * Get all tests passing. * Fix style. * Update changelog. * Update changelog. * Address all PR comments except for renaming init_project parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the various backwards compatibility layers that have been introduced on next to mitigate the pain of migrating to signac 2.0. Some other deprecated code that has previously slipped through the cracks is removed as well.
Motivation and Context
Based on discussions in some recent PRs (primarily #685 and #714) as well as more extended consideration in our developer meeting, we have decided against including backwards compatibility layers signac 2.0. Previously, we had incorporated some level of compatibility for changes that we foresaw having a particularly wide impact, but per our more recent discussions we will be moving forward with making these changes breaking in 2.0 since none of them are very difficult for users to fix.
Checklist: