Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sharing the progress on this issue: #608
So far, these are the changes I've made:
window_background_type
andwindow_background_image
Terminator.reconfigure
is called, also apply config to the windowsThe feature 3. was added with the first commit. I don't see any reason for the windows not to apply the config without restarting. This makes it so that the global background image changes without restart, but also all the other settings (fullscreen, always on top...).
Still not ready to merge. Missing features:
Introduced bugs:
Also, are the names
window_background_type
andwindow_background_image
ok?