Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow additional metric configuration in ReportDBStatsMetrics #33

Merged
merged 1 commit into from
Nov 24, 2024
Merged

allow additional metric configuration in ReportDBStatsMetrics #33

merged 1 commit into from
Nov 24, 2024

Conversation

steved
Copy link
Contributor

@steved steved commented Nov 22, 2024

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

Allows providing additional configuration when using ReportDBStatsMetrics directly.

User Case Description

I'm calling it directly with an additional database name attribute:

metrics.ReportDBStatsMetrics(sqlDB, metric.WithAttributes(attribute.String("db", ...)))

@zstone12
Copy link
Collaborator

LGTM

@zstone12 zstone12 merged commit 68c1f9a into go-gorm:master Nov 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steved @zstone12