refactor: adjust comment and remove 1.12 support (#338)

go-webauthn · Nov 26, 2024 · 0cd5289 · 0cd5289
1 parent 77b369a
commit 0cd5289
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 42 deletions.
diff --git a/protocol/base64.go b/protocol/base64.go
@@ -22,9 +22,8 @@ func (e *URLEncodedBase64) UnmarshalJSON(data []byte) error {
 		return nil
 	}
 
-	// TODO: Investigate this line. It is commented as trimming the leading spaces but appears to trim the leading and trailing double quotes instead.
-	// Trim the leading spaces.
-	data = bytes.Trim(data, "\"")
+	// Trim the leading and trailing quotes from raw JSON data (the whole value part)
+	data = bytes.Trim(data, `"`)
 
 	// Trim the trailing equal characters.
 	data = bytes.TrimRight(data, "=")

diff --git a/protocol/webauthncose/ed25519.go b/protocol/webauthncose/ed25519.go
@@ -1,5 +1,3 @@
-//go:build go1.13
-
 package webauthncose
 
 import (

diff --git a/protocol/webauthncose/ed25519_go112.go b/protocol/webauthncose/ed25519_go112.go