Repository navigation
fix(plugins): allow complete LoggingPlugin output - #7489
Open
Manitchahar wants to merge 1 commit into
Open
Manitchahar wants to merge 1 commit into
Manitchahar wants to merge 1 commit into
Conversation
Expose the existing content and argument limits as keyword-only options. Preserve current defaults and accept None to disable truncation. Fixes google#6056
This was referenced Oct 10, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
main.Problem:
LoggingPluginhard-codes truncation at 200 characters for text parts and system instructions, and 300 for tool arguments/results. Error details at the end of a long tool result never reach the log.Solution:
Add two keyword-only constructor options. Defaults are unchanged;
Nonedisables truncation.Only
logging_plugin.pyand its test file are touched.Testing Plan
Unit Tests:
tests/unittests/plugins/test_logging_plugin.py: 31 passed on currentmain(20 new cases covering custom limits, exact-boundary lengths, zero, andNone). Previously verified on Python 3.10–3.14.Manual End-to-End (E2E) Tests:
Ran a real
InMemoryRunnerwith a scripted localBaseLlmthat calls a tool returning a long diagnostic. A marker placed after the default cutoff is hidden with the defaults and visible with custom orNonelimits, for tool results, model responses and system instructions.Checklist
Additional context
Companion docs PR: google/adk-docs#2215
🤖 Generated with Claude Code