Repository navigation
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Shay-Deng
force-pushed
the
fix/7480-empty-thinking-blocks
branch
from
October 11, 2026 00:05
15659a0 to
1b91520
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related to #7480, item 3 (empty thinking blocks).
When Claude returns a signed thinking block with an empty string, AnthropicLlm converts it back into a redacted_thinking block on the next request and uses the signature as the encrypted data. This changes the model history that should be preserved.
Distinguish an empty string from missing text when serializing thought parts. Empty and nonempty thinking blocks keep their original type, text, and signature; genuine redacted blocks, whose text is None, retain their existing representation. This patch does not address the separate sub-agent isolation and date serialization reports in #7480.
Testing Plan
pytest tests/unittests/models/test_anthropic_llm.pypasses all 175 tests.The E2E check uses real Runner, AnthropicLlm, AsyncAnthropic and an HTTP MockTransport, without a live model or real API credentials. One tool call produces two requests and three serialized Runner events; the second request must retain the exact signed thinking block and tool block order.
Before:
After (source checkout and installed wheel):
Offline Runner reproduction
Validated using Python 3.12.14, anthropic 1.13.0 and google-genai 2.29.0. Save the script below as
reproduce_empty_thinking.py. In a fresh environment, run these commands from the repository root:To check the built wheel, replace
-e .withdist/google_adk-2.11.0-py3-none-any.whlin the install command. The pinned Anthropic SDK provides thehttpx2transport used by this reproduction.AI assistance was used for investigation, implementation, and testing.