Repository navigation
refactor!: Pass workflow settings by value - #4679
Merged
gmlewis merged 2 commits intoOct 28, 2026
Merged
Conversation
Rename the shared workflow permissions request and pass it by value in the repository, organization, and enterprise settings methods. Preserve boolean JSON behavior and update generated accessors and tests. BREAKING CHANGE: WorkflowsPermissionsOpt is renamed to WorkflowsPermissionsRequest. The three UpdatePrivateRepoForkPRWorkflowSettings methods now take the request by value instead of by pointer. Updates google#3644
55408suga
marked this pull request as ready for review
October 27, 2026 13:14
gmlewis
added
NeedsReview
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4679 +/- ##
=======================================
Coverage 98.63% 98.63%
=======================================
Files 201 201
Lines 18951 18951
=======================================
Hits 18693 18693
Misses 258 258 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-authored-by: Dhananjay Mishra <technicaldmcontact@gmail.com>
Collaborator
|
Thank you, @Not-Dhananjay-Mishra! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename
WorkflowsPermissionsOpttoWorkflowsPermissionsRequestand pass it by value in the repository, organization, and enterprise fork PR workflow settings methods.Preserve existing JSON behavior, including the distinction between omitted optional booleans and explicit
false. Update tests and generated accessors, and remove the obsolete linter exception.Updates #3644.
BREAKING CHANGE: Callers must use
WorkflowsPermissionsRequestvalues instead of*WorkflowsPermissionsOpt.Validation:
script/generate.shscript/fmt.shscript/test.sh(all modules, with race detection)script/lint.shgo test -tags=integration -run='^$' ./test/integration(compile only)AI assistance: An AI coding agent (Codex) drafted the code, tests, and this description. I reviewed the diff and ran the validation steps above locally.