Repository navigation
docs: fix "Bellow" typo in enterprise SCIM struct comments - #4691
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4691 +/- ##
=======================================
Coverage 98.64% 98.64%
=======================================
Files 202 202
Lines 19004 19004
=======================================
Hits 18746 18746
Misses 258 258 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4690.
github/enterprise_scim.gohas two doc comments that start withBellow:where the intended word isBelow::SCIMEnterpriseGroupAttributes—// Bellow: Only populated as a result of calling UpdateSCIMGroupAttribute:SCIMEnterpriseUserAttributes—// Bellow: Only populated as a result of calling UpdateSCIMUserAttribute:Both comments sit directly above the
IDfield of their struct, where "Below" is what is meant.The change is two comment lines and nothing else: no exported identifier, no JSON tag, no behaviour change.
gofmtandgo vetare clean on the file, andscript/test.shpasses without modification since only comments changed.Per the contributing guide I opened issue #4690 first and am keeping the diff to a single file.