Skip to content

docs: fix "Bellow" typo in enterprise SCIM struct comments - #4691

Merged
gmlewis merged 1 commit into
google:masterfrom
Jah-yee:fix/scim-bellow-doc-typo
Oct 30, 2026
Merged

gmlewis merged 1 commit into
google:masterfrom
Jah-yee:fix/scim-bellow-doc-typo

Conversation

@Jah-yee

@Jah-yee Jah-yee commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Fixes #4690.

github/enterprise_scim.go has two doc comments that start with Bellow: where the intended word is Below::

  • line 37, SCIMEnterpriseGroupAttributes — // Bellow: Only populated as a result of calling UpdateSCIMGroupAttribute:
  • line 103, SCIMEnterpriseUserAttributes — // Bellow: Only populated as a result of calling UpdateSCIMUserAttribute:

Both comments sit directly above the ID field of their struct, where "Below" is what is meant.

The change is two comment lines and nothing else: no exported identifier, no JSON tag, no behaviour change. gofmt and go vet are clean on the file, and script/test.sh passes without modification since only comments changed.

Per the contributing guide I opened issue #4690 first and am keeping the diff to a single file.

@gmlewis gmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Jah-yee!
Merging.

@gmlewis
gmlewis merged commit 09ce62f into google:master Oct 30, 2026
13 checks passed
@codecov

codecov Bot commented Oct 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.64%. Comparing base (d81aef7) to head (2c0fb90).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4691   +/-   ##
=======================================
  Coverage   98.64%   98.64%           
=======================================
  Files         202      202           
  Lines       19004    19004           
=======================================
  Hits        18746    18746           
  Misses        258      258           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typo: "Bellow:" should be "Below:" in enterprise SCIM struct comments

2 participants