Repository navigation
Typecheck Source/Sink method calls on proc members - #5112
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
Calls like `self.input.recv()` resolve to the stubbed methods in `builtin_stubs.x`. The implicit-token check assumed every builtin is called by its bare name, e.g. `assert_eq(...)`, and crashed on a method call, where the callee is `self.input.recv`. It now skips methods. PiperOrigin-RevId: 995978884
copybara-service
Bot
force-pushed
the
test_995978884
branch
from
October 8, 2026 19:22
8091358 to
e573173
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typecheck
Source/Sinkmethod calls on proc membersCalls like
self.input.recv()resolve to the stubbed methods inbuiltin_stubs.x. The implicit-token check assumed every builtin is called by its bare name, e.g.assert_eq(...), and crashed on a method call, where the callee isself.input.recv. It now skips methods.