Repository navigation
Format repeated input filenames only once - #1343
Open
vinsymoyya wants to merge 1 commit into
Open
vinsymoyya wants to merge 1 commit into
vinsymoyya wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1342.
YAPF formats every occurrence of a filename, so overlapping inputs such as
yapf -r src src/example.pyemit the same source twice. Repeated inputs also duplicate diffs and submit redundant parallel jobs.Deduplicate filename strings once at the
FormatFilesboundary, preserving first-occurrence order for sequential formatting. This benefits both CLI and direct callers. Document the behavior and add real CLI tests for repeated file arguments, ordering, recursive overlaps, and parallel mode. Path spellings and alias resolution remain unchanged.Validation on Windows, Python 3.12.13:
python -m pytest -q: 613 passed, 2 subtests passed.git diff --checkpasses.Deduplication uses exact filename strings; differently spelled paths to the same file remain distinct.
Upstream CI and maintainer review are pending.