docs: Add warning note about user provided credential configurations. #2916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanda-tarafa
added
the
do not merge
|
FYI @sai-sunder-s @jskeet Not to be merged until confirmation |
| /// Providing an unvalidated credential configuration to Google APIs can compromise the security of your | ||
| /// systems and data. For more information, refer to | ||
| /// <see href="https://cloud.google.com/docs/authentication/external/externally-sourced-credentials">Validate credential configurations from external sources</see>. | ||
| /// </remarks> |
There was a problem hiding this comment.
Do we need to update here? Only SA json can be accepted here right?
There was a problem hiding this comment.
Started an internal thread.
There was a problem hiding this comment.
We discussed internally, removing from here as it's not necessary.
jskeet
approved these changes
Jan 17, 2025
Towards b/389125232
amanda-tarafa
force-pushed
the
warning
branch
from
b565bad to
c7c4e27
Compare
sai-sunder-s
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards b/389125232