Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add multi-approvers check #1612

Merged
merged 5 commits into from
Jan 17, 2025
Merged

chore: add multi-approvers check #1612

merged 5 commits into from
Jan 17, 2025

Conversation

meltsufin
Copy link
Member

Initialized the members list with the Java team members.
More info on this workflow: https://github.com/abcxyz/pkg?tab=readme-ov-file#multi-approversyml

@meltsufin meltsufin requested review from a team as code owners January 14, 2025 03:47
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jan 14, 2025
@meltsufin
Copy link
Member Author

abcxyz/pkg#363

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@meltsufin meltsufin requested a review from suztomo January 17, 2025 02:01
@meltsufin
Copy link
Member Author

The check seems to be working:

Pull request login meltsufin is a member of the org, therefore no special approval rules apply.

suztomo
suztomo approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this. I want to see how it works.

@meltsufin meltsufin merged commit e51930f into main Jan 17, 2025
20 checks passed
@meltsufin meltsufin deleted the multi-approvers branch January 17, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqiu96 lqiu96 lqiu96 left review comments

@suztomo suztomo suztomo approved these changes

Assignees
No one assigned
Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meltsufin @suztomo @lqiu96