Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove region tags #4770

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

camiekim
Copy link
Contributor

Per b/296916003

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Per b/296916003
@camiekim camiekim requested review from yoshi-approver and a team as code owners October 27, 2023 13:36
@snippet-bot
Copy link

snippet-bot bot commented Oct 27, 2023

Here is the summary of changes.

You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@ddelgrosso1
Copy link
Contributor

Hi @camiekim per the buganizer issue you linked should these be replaced with workflows_client_library as opposed to just removing them?

@camiekim
Copy link
Contributor Author

Hi @ddelgrosso1, there is already an existing Node.js sample with the correct region tag (now) that is being used here: https://cloud.google.com/workflows/docs/samples/workflows-client-library?hl=en#workflows_client_library-nodejs_javascript

Thanks for checking though!

@ddelgrosso1
Copy link
Contributor

/gcbrun

@alexander-fenster
Copy link
Contributor

/gcbrun

@alexander-fenster alexander-fenster merged commit c158064 into googleapis:main Nov 3, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants